Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(StatusQ/SubmodelProxyModel): Exposing roles computed per submodel to the top-level model #14541

Merged
merged 1 commit into from May 7, 2024
Merged

feat(StatusQ/SubmodelProxyModel): Exposing roles computed per submodel to the top-level model #14541

merged 1 commit into from May 7, 2024

Conversation

micieslak
Copy link
Member

@micieslak micieslak commented Apr 29, 2024 •
edited

What does the PR do

  • adds possibility to expose values computed per submodel as a role to top-level model in a dynamic, declarative way
  • extends the existing Storybook page to present added functionality, adds intro describing the flow
  • adds test (marked with SKIP(...)) pointing the problem with creating multiple proxies over the same source (to be fixed in a separate task: feat(StatusQ): Make SubmodelProxyModel non-intrusive and generalized #14550)
Screencast.from.29.04.2024.16.07.21.webm

Closes: #14390

Affected areas

SubmodelProxyModel

@status-im-auto
Copy link
Member

status-im-auto commented Apr 29, 2024 •
edited

Jenkins Builds

Click to see older builds (25)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ce6e7c4 #1 2024-04-29 14:02:06 ~7 min tests/nim 📄log
✔️ ce6e7c4 #1 2024-04-29 14:04:06 ~9 min macos/aarch64 🍎dmg
✔️ ce6e7c4 #1 2024-04-29 14:05:23 ~10 min macos/x86_64 🍎dmg
✔️ ce6e7c4 #1 2024-04-29 14:06:21 ~11 min tests/ui 📄log
✔️ ce6e7c4 #1 2024-04-29 14:13:03 ~18 min linux/x86_64 📦tgz
✔️ ce6e7c4 #1 2024-04-29 14:19:19 ~24 min windows/x86_64 💿exe
✔️ f2855c5 #2 2024-04-29 22:29:09 ~5 min macos/aarch64 🍎dmg
✔️ f2855c5 #2 2024-04-29 22:29:57 ~6 min tests/nim 📄log
✔️ f2855c5 #2 2024-04-29 22:31:38 ~8 min macos/x86_64 🍎dmg
✔️ f2855c5 #2 2024-04-29 22:35:08 ~11 min tests/ui 📄log
✔️ f2855c5 #2 2024-04-29 22:39:28 ~16 min linux/x86_64 📦tgz
✔️ f2855c5 #2 2024-04-29 22:46:30 ~22 min windows/x86_64 💿exe
✔️ 3a47811 #3 2024-04-30 07:50:56 ~6 min tests/nim 📄log
✔️ 3a47811 #3 2024-04-30 07:52:02 ~7 min macos/x86_64 🍎dmg
❌ 3a47811 #3 2024-04-30 07:55:26 ~11 min tests/ui 📄log
✔️ 3a47811 #3 2024-04-30 08:00:33 ~16 min linux/x86_64 📦tgz
✔️ 3a47811 #3 2024-04-30 08:00:56 ~16 min macos/aarch64 🍎dmg
✔️ 3a47811 #3 2024-04-30 08:07:26 ~23 min windows/x86_64 💿exe
✔️ 3a47811 #4 2024-04-30 09:07:32 ~7 min tests/ui 📄log
✔️ 629e230 #4 2024-04-30 11:24:26 ~6 min tests/nim 📄log
✔️ 629e230 #4 2024-04-30 11:25:53 ~8 min macos/x86_64 🍎dmg
✔️ 629e230 #5 2024-04-30 11:29:14 ~11 min tests/ui 📄log
✔️ 629e230 #4 2024-04-30 11:33:34 ~16 min linux/x86_64 📦tgz
✔️ 629e230 #4 2024-04-30 11:34:16 ~16 min macos/aarch64 🍎dmg
✔️ 629e230 #4 2024-04-30 11:40:51 ~23 min windows/x86_64 💿exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3a6a826 #5 2024-04-30 11:55:26 ~6 min tests/nim 📄log
✔️ 3a6a826 #5 2024-04-30 11:56:14 ~7 min macos/x86_64 🍎dmg
✔️ 3a6a826 #6 2024-04-30 11:59:45 ~10 min tests/ui 📄log
✔️ 3a6a826 #5 2024-04-30 12:03:00 ~14 min macos/aarch64 🍎dmg
✔️ 3a6a826 #5 2024-04-30 12:04:58 ~16 min linux/x86_64 📦tgz
✔️ 3a6a826 #5 2024-04-30 12:10:48 ~21 min windows/x86_64 💿exe
✔️ f1add5c #6 2024-05-07 13:59:07 ~6 min macos/aarch64 🍎dmg
✔️ f1add5c #6 2024-05-07 13:59:32 ~6 min tests/nim 📄log
✔️ f1add5c #6 2024-05-07 14:03:08 ~10 min macos/x86_64 🍎dmg
✔️ f1add5c #7 2024-05-07 14:04:29 ~11 min tests/ui 📄log
✔️ f1add5c #6 2024-05-07 14:08:34 ~15 min linux/x86_64 📦tgz
✔️ f1add5c #6 2024-05-07 14:17:01 ~24 min windows/x86_64 💿exe

caybro
caybro reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, just some small objections/remarks

ui/StatusQ/include/StatusQ/submodelproxymodel.h Outdated Show resolved Hide resolved
ui/StatusQ/src/submodelproxymodel.cpp Outdated Show resolved Hide resolved
ui/StatusQ/src/submodelproxymodel.cpp Outdated Show resolved Hide resolved
ui/StatusQ/src/submodelproxymodel.cpp Outdated Show resolved Hide resolved
@micieslak micieslak requested a review from caybro April 29, 2024 22:28
@micieslak micieslak requested a review from friofry April 30, 2024 07:46
caybro
caybro reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more remarks, sorry :)

ui/StatusQ/src/submodelproxymodel.cpp Outdated Show resolved Hide resolved
ui/StatusQ/src/submodelproxymodel.cpp Outdated Show resolved Hide resolved
ui/StatusQ/src/submodelproxymodel.cpp Outdated Show resolved Hide resolved
ui/StatusQ/src/submodelproxymodel.cpp Show resolved Hide resolved
@micieslak
Copy link
Member Author

A few more remarks, sorry :)

Any comments are always welcome! :)

@micieslak micieslak requested a review from caybro April 30, 2024 11:20
caybro
caybro approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@micieslak micieslak mentioned this pull request Apr 30, 2024
Open
Seitseman
Seitseman approved these changes May 7, 2024
View reviewed changes
ui/StatusQ/src/submodelproxymodel.cpp Outdated Show resolved Hide resolved
@micieslak micieslak merged commit 27c53f4 into master May 7, 2024
8 checks passed
@micieslak micieslak deleted the feat/issue-14390 branch May 7, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caybro caybro caybro approved these changes

@Seitseman Seitseman Seitseman approved these changes

@alexjba alexjba Awaiting requested review from alexjba

@noeliaSD noeliaSD Awaiting requested review from noeliaSD

@friofry friofry Awaiting requested review from friofry

@stefandunca stefandunca Awaiting requested review from stefandunca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(StatusQ/SubmodelProxyModel): Allow defining new proxy roles via delegateModel component
4 participants
@micieslak @status-im-auto @Seitseman @caybro