fix: Hide members count from community cards when the community is en… #14538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crypted and the community info is not available
alexjba
requested review from
Seitseman,
caybro,
micieslak,
igor-sirotin and
osmaczko
1 task
caybro
approved these changes
Apr 29, 2024
|
|
||
| proc getEncrypted*(self: CuratedCommunityItem): bool = | ||
| return self.encrypted |
There was a problem hiding this comment.
it's more or less inline with the style used in each file. Here is return self.x, in src/app_service/service/message/dto/status_community_link_preview.nim is something like result = self.x
Jenkins Builds
|
igor-sirotin
approved these changes
Apr 29, 2024
alexjba
deleted the
13192-dont-display-number-of-members-for-token-gated-communities-on-previews
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…crypted and the community info is not available
What does the PR do
closes #13192
Changes:
encryptedandjoinedflags in the link preview model and curated communities modelAffected areas
Link previews
Communities portal
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-04-29.at.14.59.25.mov
Cool Spaceship Picture