fix(TokenUI): Hide explicitly ManageTokensCommunityTag in community settings page #14500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (18)
|
noeliaSD
reviewed
Apr 23, 2024
ui/app/AppLayouts/Wallet/views/collectibles/CollectibleView.qml
Outdated
Show resolved
Hide resolved
|
Checking Figma Communities P3 -> Tokens , it looks like indeed communityId should not be set on MintedTokensView component. |
noeliaSD
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Tested again and works fine!
Thanks for addressing the comments! I've added some other minor ones, please take a look. Otherwise, LGTM!
You will need to rebase on top of master to make the e2e tests work properly since there have been some changes there that are making this pr failing in this job!
| @@ -178,6 +178,7 @@ Control { | |||
| } | |||
|
|
|||
| ManageTokensCommunityTag { | |||
| id: manageTokenCommunityTag | |||
There was a problem hiding this comment.
Do we need then this id here?
1 task
endulab
approved these changes
May 6, 2024
Seitseman
force-pushed
the
13220-token-ui-is-corrupted-in-the-community-tokens-settings
branch
from
1570e50
to
a3cb7c0
Compare
…ettings page according to collectibles cells sizing
Seitseman
force-pushed
the
13220-token-ui-is-corrupted-in-the-community-tokens-settings
branch
from
a3cb7c0
to
6efc043
Compare
Seitseman
deleted the
13220-token-ui-is-corrupted-in-the-community-tokens-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
PR hide the ManageTokensCommunityTag item in "Community"->Tokens page. Previous changes introduced ManageTokensCommunityTag 12519 ManageTokensCommunityTag for displaying community icon and name when showing Collectibles in User's Wallet->Collectibles page. However when going to particular Community and checking its "Tokens" there is no need to display that tag, according to the MintedTokensSettingsPanel PR: 11347
Affected areas
Wallet
Communities
StatusQ checklist
Screenshot of functionality (including design for comparison)
In Wallet -> Collectibles, ManageTokensCommunityTag is displayed: