feat(ProfileShowcase): Implement custom showcase position when searcher text is filtering items #14486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
caybro
approved these changes
Apr 19, 2024
ui/app/AppLayouts/Profile/panels/ProfileShowcaseAccountsPanel.qml
Outdated
Show resolved
Hide resolved
micieslak
reviewed
Apr 30, 2024
There was a problem hiding this comment.
I really like the approach, it organizes things nicely. Only some small questions here.
And as a future ideas:
- bulk set(...) method for WritableModel - it would prevent from many dataChange signals and other reevaluations later in the flow
- custom proxy just for DnD, simpler than MovableModel, converting dataChanged from source into rowsMoved signals
ui/app/AppLayouts/Profile/helpers/VisibilityAndPositionDirtyStateModel.qml
Outdated
Show resolved
Hide resolved
alexjba
force-pushed
the
13682-profile-showcase-custom-positioning-when-reordering-a-filtered-in-showcase-list
branch
from
8e3625a
to
be9d6e9
Compare
✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-14486#2 🔹 ~6 min 40 sec 🔹 be9d6e9 🔹 📦 tests/nim package |
|
@micieslak Good point! I've updated this PR and created two additional tasks: Feel free to update them. |
alexjba
force-pushed
the
13682-profile-showcase-custom-positioning-when-reordering-a-filtered-in-showcase-list
branch
from
be9d6e9
to
800fa13
Compare
micieslak
approved these changes
May 16, 2024
…er text is filtering items
alexjba
force-pushed
the
13682-profile-showcase-custom-positioning-when-reordering-a-filtered-in-showcase-list
branch
from
800fa13
to
8185f1d
Compare
alexjba
deleted the
13682-profile-showcase-custom-positioning-when-reordering-a-filtered-in-showcase-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
closes #13682
closes #14040
Changes:
VisibilityAndPositionDirtyStateModel.qmlAffected areas
Profile showcase
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-04-19.at.12.47.53.mov