fix(ProfileContextMenu): don't overflow the title #14484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not display the "Send contact request" menu item when we've already sent one; happened because now we have an enum for the contact request state
- calculate the text width correctly, taking into account all the contents (verifications icons, edit button) and also the margins Fixes #14462
caybro
requested review from
igor-sirotin,
Seitseman,
micieslak,
alexjba and
noeliaSD
Jenkins Builds
|
micieslak
approved these changes
Apr 26, 2024
caybro
deleted the
14462-untrusted-and-contact-marker-clipped-in-profile-context-menu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #14462
Affected areas
ProfileContextMenu
Screenshot of functionality (including design for comparison)
No clipped icons:
Pending CR + context menu:
