feat: Add initial support for ChartJs plugins #14433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (18)
|
alexjba
force-pushed
the
13936-walletgraph-analyze-all-graph-use-cases-needed-and-confirm-what-can-be-done
branch
from
1e4e09a
to
02b00fa
Compare
caybro
reviewed
Apr 16, 2024
ui/StatusQ/src/StatusQ/Components/private/chart/Library/Library.js
Outdated
Show resolved
Hide resolved
ui/StatusQ/src/StatusQ/Components/private/chart/ChartCanvas.qml
Outdated
Show resolved
Hide resolved
ui/StatusQ/src/StatusQ/Components/private/chart/Library/Library.js
Outdated
Show resolved
Hide resolved
ui/StatusQ/src/StatusQ/Components/private/chart/Library/Library.js
Outdated
Show resolved
Hide resolved
alexjba
force-pushed
the
13936-walletgraph-analyze-all-graph-use-cases-needed-and-confirm-what-can-be-done
branch
from
02b00fa
to
f0fe650
Compare
caybro
reviewed
Apr 23, 2024
ui/StatusQ/src/StatusQ/Components/private/chart/Library/Library.js
Outdated
Show resolved
Hide resolved
|
The |
caybro
reviewed
Apr 23, 2024
ui/StatusQ/src/StatusQ/Components/private/chart/Library/Library.js
Outdated
Show resolved
Hide resolved
caybro
reviewed
Apr 23, 2024
ui/StatusQ/src/StatusQ/Components/private/chart/Library/Library.js
Outdated
Show resolved
Hide resolved
alexjba
force-pushed
the
13936-walletgraph-analyze-all-graph-use-cases-needed-and-confirm-what-can-be-done
branch
from
f0fe650
to
ca7243d
Compare
+ adding plugin for crosshair and zoom + adding plugin for data labels
alexjba
force-pushed
the
13936-walletgraph-analyze-all-graph-use-cases-needed-and-confirm-what-can-be-done
branch
from
ca7243d
to
45d9af1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Closes #13936
Load the original Chart.JS 2.9.4 library as an IIFE module
Loading the original CharJS library will enable us to load chart plugins since most of them expect this format.
Loading the original library requires a few adaptations:
Polyfill.js- This module is responsible to provide the functionality expected by ChartJs or plugins that is traditionally provided by the web browser. Basically anything related towindowordocumentLibrary.js- This module loads the ChartJS module, plugins and Polyfills. It will provide the necessary glue code to adapt the ChartJs and plugins to the QML environment. E.g. generate mouse events, resize eventsLoad crosshair and data labels plugins
https://github.com/AbelHeinsbroek/chartjs-plugin-crosshair/tree/v1.1.3?tab=readme-ov-file
https://github.com/chartjs/chartjs-plugin-datalabels/tree/v1.0.0
Add demo charts in storybook
Screen.Recording.2024-04-16.at1.09.59.36.mov
Affected areas
Charts