Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the xTwitter new logo #14430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dicethedev
Copy link

Fix - [Profile Showcase] Wrong X (Twitter) icon #14300

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick :)

The problem here though is that we already have this new icon but under a different name. So the objective of the PR should also be to get rid of the other copy (xtwitter.svg) and adjust the QML code to just use this icon here.

Thanks for your contribution, can you pls update the PR according the above needs? Sorry if the issue wasn't explicit enough

@dicethedev
Copy link
Author

Nice trick :)

The problem here though is that we already have this new icon but under a different name. So the objective of the PR should also be to get rid of the other copy (xtwitter.svg) and adjust the QML code to just use this icon here.

Thanks for your contribution, can you pls update the PR according the above needs? Sorry if the issue wasn't explicit enough

Alright. I will look into this!

@alexjba
Copy link
Contributor

alexjba commented Apr 18, 2024

@dicethedev Have a look here
https://github.com/status-im/status-desktop/blob/master/ui/imports/utils/ProfileUtils.qml#L82

This is where we map the icon to the link type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants