fix(Communities): Introduce request id for checking community permissions #14403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (41)
|
|
@MishkaRogachev JSON rpc should already have a request id you can use: can we leverage that instead? |
you are right in case we need to identify requests between status-go and desktop, should use id from json, here the problem is a bit deeper on ui, i think when i come back to this PR i need to create a second permissions model instance to check permissions independently from the main community permissions model |
MishkaRogachev
force-pushed
the
fix/issue-14376-chat-content-updates-in-the-background-while-playing-with-the-edit-shared-popup-addresses
branch
4 times, most recently
from
c4c0f96
to
57b21a0
Compare
MishkaRogachev
force-pushed
the
fix/issue-14376-chat-content-updates-in-the-background-while-playing-with-the-edit-shared-popup-addresses
branch
2 times, most recently
from
8ef6236
to
54b9fb3
Compare
|
@caybro @mprakhov
|
mprakhov
reviewed
Apr 30, 2024
| @@ -378,7 +378,7 @@ method onAcceptRequestToJoinFailedNoPermission*(self: AccessInterface, community | |||
| method onDeactivateChatLoader*(self: AccessInterface, chatId: string) {.base.} = | |||
| raise newException(ValueError, "No implementation available") | |||
|
|
|||
| method onCommunityCheckPermissionsToJoinResponse*(self: AccessInterface, checkPermissionsToJoinResponse: CheckPermissionsToJoinResponseDto) {.base.} = | |||
| method onCommunityCheckPermissionsToJoinResponse*(self: AccessInterface, checkPermissionsToJoinResponse: CheckPermissionsToJoinResponseDto, ) {.base.} = | |||
MishkaRogachev
force-pushed
the
fix/issue-14376-chat-content-updates-in-the-background-while-playing-with-the-edit-shared-popup-addresses
branch
from
54b9fb3
to
12f3a60
Compare
|
@jrainville @mprakhov @caybro
If anyone can confirm that the problem is not reproducible in the current master, I suggest closing this PR |
If indeed the issue isn't reproducible anymore, it's not worth adding code for no reason. There might be a refactor on the permissions module later anyway |
Yeah, I'd prefer a more consistent refactoring here. Most likely it was fixed here: #13825 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #14376
What does the PR do
Screen.Recording.2024-04-29.at.13.02.38.mov
Affected areas
Communities