feat(settings): Fixed changing network urls #14353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuteivist
requested review from
alaibe,
caybro,
micieslak,
Khushboo-dev-cpp and
noeliaSD
Jenkins Builds
|
caybro
approved these changes
Apr 9, 2024
| signal updateNetworkValues(int chainId, string newMainRpcInput, string newFailoverRpcUrl, bool revertToDefault) | ||
| signal updateNetworkValues(int chainId, bool testNetwork, string newMainRpcInput, string newFailoverRpcUrl, bool revertToDefault) | ||
|
|
||
| onVisibleChanged: { |
There was a problem hiding this comment.
You could use a Binding (in order not to break with manual tab changes) here but assuming the first tab will be always prod this is good imo :)
Cuteivist
force-pushed
the
bug/revert-networks-notification-14228
branch
from
14bd68c
to
01f086e
Compare
IvanBelyakoff
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task #14228
What does the PR do
NOTE this is executed in onVisibleChanged because normal binding would be broken when tabs are manually changed.
Affected areas
Settings / networks
Screenshot of functionality (including design for comparison)
network_settings.mp4