Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't display number of members for token-gated communities on previews #13192

Closed
1 task
osmaczko opened this issue Jan 11, 2024 · 1 comment · Fixed by #14538
Closed
1 task

Don't display number of members for token-gated communities on previews #13192

osmaczko opened this issue Jan 11, 2024 · 1 comment · Fixed by #14538
Assignees
@alexjba
Labels
bug Something isn't working E:Desktop Bugfixes 2.29.0 ui-team
Milestone
2.29.0 Beta

Comments

@osmaczko
Copy link
Contributor

Description

Currently, community preview cards display the number of members (and active members). This data is encrypted for token-gated communities, resulting in a display of 0 for non-members (peers who can't decrypt the data). In such cases, these stats should be hidden.

Acceptance criteria:

  • Hide the numbers of members and active members in community previews for token-gated communities if the user is not a member of that community.
@osmaczko osmaczko mentioned this issue Jan 11, 2024
Open
@iurimatias iurimatias added this to the 2.29.0 Beta milestone Feb 26, 2024
@alexandraB99 alexandraB99 added bug Something isn't working E:Desktop Bugfixes 2.29.0 labels Mar 1, 2024
@noeliaSD noeliaSD self-assigned this Apr 5, 2024
@noeliaSD noeliaSD assigned alexjba and unassigned noeliaSD Apr 26, 2024
@alexjba alexjba mentioned this issue Apr 29, 2024
Merged
@alexjba alexjba linked a pull request Apr 29, 2024 that will close this issue
fix: Hide members count from community cards when the community is en… #14538
Merged
@alexjba
Copy link
Contributor

alexjba commented Apr 30, 2024

I've handled here the community previews in the link previews and curated community cards. But looks like we need the same approach in every place where the community members are shown. Will create a new task for this. I think we'll first need an analysis to spot all these places.

Image
Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexjba alexjba

Labels
bug Something isn't working E:Desktop Bugfixes 2.29.0 ui-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.29.0 Beta
Development

Successfully merging a pull request may close this issue.

fix: Hide members count from community cards when the community is en… status-im/status-desktop
5 participants
@iurimatias @alexandraB99 @osmaczko @alexjba @noeliaSD