Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet/Graph] Analyze all graph use cases needed and confirm what can be done #13936

Open
Tracked by #13838
alexandraB99 opened this issue Mar 12, 2024 · 1 comment · May be fixed by #14433
Open
Tracked by #13838

[Wallet/Graph] Analyze all graph use cases needed and confirm what can be done #13936

alexandraB99 opened this issue Mar 12, 2024 · 1 comment · May be fixed by #14433
Assignees
@alexjba
Labels
E:Desktop Features 2.29.0 feature ui-team
Milestone
2.29.0 Beta

Comments

@alexandraB99
Copy link
Contributor

Description

  • List the needed features
  • Check if the current version of the component supports these features
  • If not, check on the possibility of update version
  • Plus: look at other qml wrapper components that can maybe offer us better benefits
@alexandraB99 alexandraB99 added this to the 2.29.0 Beta milestone Mar 12, 2024
@alexandraB99 alexandraB99 mentioned this issue Mar 12, 2024
Open
16 tasks
@alexandraB99 alexandraB99 changed the title [Wallet/Graph] Analyze all graph use cases needed to confirm what can be done [Wallet/Graph] Analyze all graph use cases needed to confirm what can be done Mar 12, 2024
@alexandraB99 alexandraB99 changed the title [Wallet/Graph] Analyze all graph use cases needed to confirm what can be done [Wallet/Graph] Analyze all graph use cases needed and confirm what can be done Mar 12, 2024
@alexjba alexjba self-assigned this Mar 15, 2024
@alexjba alexjba modified the milestones: 2.29.0 Beta, 2.28.0 Beta Mar 15, 2024
@alexjba alexjba modified the milestones: 2.28.0 Beta, 2.28.1 Beta Mar 25, 2024
@alexjba alexjba linked a pull request Apr 16, 2024 that will close this issue
feat: Add initial support for ChartJs plugins #14433
Open
@alexjba alexjba linked a pull request Apr 16, 2024 that will close this issue
Open
@alexjba
Copy link
Contributor

alexjba commented Apr 22, 2024 •
edited

ChartJs supports all of our needs, but to speed-up the development we need to use some ChartJs plugins. Unfortunately to support the latest ChartJS version (or at least a 3.x) we'll need to adapt the ChartJs library to Qt's more limited standard support. Haven't found any reason to invest more time in this because the latest 2.x version is sufficient for the wallet graphs. The only additional feature we could use from the latest ChartJS versions is the data decimation, but it's not mandatory.

That this task will provide:

  1. Out of the box support for ChartJs plugins supporting ChartJs 2.9.4. (https://www.npmjs.com/search?q=chartjs-plugin-, https://github.com/chartjs/awesome) and QML integration
  2. Integrated Crosshair plugin - this adds basic support for zoom, pan and crosshair
  3. Integrated DataLabel plugin
  4. Adding Storybook examples
  5. Update/create the necessary tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexjba alexjba

Labels
E:Desktop Features 2.29.0 feature ui-team
Projects
Status Desktop/Mobile Board
Status: Code review
Milestone
2.29.0 Beta
Development

Successfully merging a pull request may close this issue.

feat: Add initial support for ChartJs plugins status-im/status-desktop
2 participants
@alexandraB99 @alexjba