fix: mitigate permissions stuck in pending on control node promotion

This PR fixes #14023 UI does NOT allow promoting to control node is no Owner token is present
status-im · May 8, 2024 · 1f312be · 1f312be
1 parent 9ca5fb7
commit 1f312be
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/ui/app/AppLayouts/Communities/panels/OverviewSettingsFooter.qml b/ui/app/AppLayouts/Communities/panels/OverviewSettingsFooter.qml
@@ -19,6 +19,7 @@ Control {
 
     // Community transfer ownership related props:
     required property bool isPendingOwnershipRequest
+    required property bool isOwnerTokenPresent
 
     signal exportControlNodeClicked
     signal importControlNodeClicked
@@ -45,6 +46,7 @@ Control {
         id: mainGrid
         columnSpacing: 16
         rowSpacing: 16
+        visible: root.isOwnerTokenPresent
 
         StatusRoundIcon {
             id: icon

diff --git a/ui/app/AppLayouts/Communities/panels/OverviewSettingsPanel.qml b/ui/app/AppLayouts/Communities/panels/OverviewSettingsPanel.qml
@@ -189,6 +189,8 @@ StackLayout {
     Component {
         id: overviewSettingsFooterComp
 
+        property bool ownerTokenCompleted: !!root.ownerToken && root.ownerToken.deployState === Constants.ContractTransactionStatus.Completed
+
         OverviewSettingsFooter {
             rightPadding: 64
             leftPadding: 64
@@ -198,18 +200,18 @@ StackLayout {
             communityColor: root.color
             isControlNode: root.isControlNode
             isPendingOwnershipRequest: root.isPendingOwnershipRequest
+            isOwnerTokenPresent: isControlNode || ownerTokenCompleted
 
             onExportControlNodeClicked:{
-                if(!!root.ownerToken && root.ownerToken.deployState === Constants.ContractTransactionStatus.Completed) {
+                if(ownerTokenCompleted) {
                     root.exportControlNodeClicked()
                 } else {
                     Global.openPopup(transferOwnershipAlertPopup, { mode: TransferOwnershipAlertPopup.Mode.MoveControlNode })
                 }
             }
             onImportControlNodeClicked: root.importControlNodeClicked()
             onFinaliseOwnershipTransferClicked: root.finaliseOwnershipClicked()
-            //TODO update once the domain changes
-            onLearnMoreClicked: Global.openLink(Constants.statusHelpLinkPrefix + "status-communities/about-the-control-node-in-status-communities")
+            onLearnMoreClicked: Global.openLink(Constants.statusHelpLinkPrefix + "communities/about-the-control-node-in-status-communities")
         }
     }