add packages to Nix flake config, move to repo root #6180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubgs
force-pushed
the
nix-flake-packages
branch
from
525f11f
to
3f57f67
Compare
|
Looks like the Seems like a bug. It works fie locally using |
jakubgs
commented
Apr 6, 2024
jakubgs
force-pushed
the
nix-flake-packages
branch
from
3f57f67
to
2ba3ad3
Compare
jakubgs
force-pushed
the
nix-flake-packages
branch
from
2ba3ad3
to
64d38a8
Compare
arnetheduck
reviewed
Apr 11, 2024
jakubgs
force-pushed
the
nix-flake-packages
branch
from
64d38a8
to
cb8d362
Compare
jakubgs
added a commit
to status-im/Nim
that referenced
this pull request
Apr 18, 2024
Because `isGitRepo()` call requires `/bin/sh` it will always fail when building Nim in a Nix build sandbox, and the check doesn't even make sense if Nix already provides Nimble source code. Since for Nimble `allowBundled` is set to `true` this effectlvely does not change behavior for normal builds, but does avoid ugly hacks when building in Nix. Reference: status-im/nimbus-eth2#6180 (comment) Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/Nim
that referenced
this pull request
Apr 18, 2024
Because `isGitRepo()` call requires `/bin/sh` it will always fail when building Nim in a Nix build sandbox, and the check doesn't even make sense if Nix already provides Nimble source code. Since for Nimble `allowBundled` is set to `true` this effectlvely does not change behavior for normal builds, but does avoid ugly hacks when building in Nix which lacks `/bin/sh` and fails to call `git`. Reference: status-im/nimbus-eth2#6180 (comment) Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
nix-flake-packages
branch
3 times, most recently
from
e63c47c
to
6d02a0f
Compare
Araq
pushed a commit
to nim-lang/Nim
that referenced
this pull request
Apr 18, 2024
Because `isGitRepo()` call requires `/bin/sh` it will always fail when building Nim in a Nix build sandbox, and the check doesn't even make sense if Nix already provides Nimble source code. Since for Nimble `allowBundled` is set to `true` this effectlvely does not change behavior for normal builds, but does avoid ugly hacks when building in Nix which lacks `/bin/sh` and fails to call `git`. Reference: * status-im/nimbus-eth2#6180 (comment) Signed-off-by: Jakub Sokołowski <jakub@status.im>
narimiran
pushed a commit
to nim-lang/Nim
that referenced
this pull request
Apr 18, 2024
Because `isGitRepo()` call requires `/bin/sh` it will always fail when building Nim in a Nix build sandbox, and the check doesn't even make sense if Nix already provides Nimble source code. Since for Nimble `allowBundled` is set to `true` this effectlvely does not change behavior for normal builds, but does avoid ugly hacks when building in Nix which lacks `/bin/sh` and fails to call `git`. Reference: * status-im/nimbus-eth2#6180 (comment) Signed-off-by: Jakub Sokołowski <jakub@status.im> (cherry picked from commit d6823f4)
jakubgs
force-pushed
the
nix-flake-packages
branch
3 times, most recently
from
e77cd7c
to
bc3d838
Compare
jakubgs
force-pushed
the
nix-flake-packages
branch
from
bc3d838
to
068b8fe
Compare
This way we can actually build and run a node using just: ```sh nix run 'github:status-im/nimbus-eth2?submodules=1' ``` The `?submodules=1` part should eventually not be necessary. For more details see: NixOS/nix#4423 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
nix-flake-packages
branch
from
068b8fe
to
4a1a2c8
Compare
tersec
approved these changes
May 6, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can actually build and run a beacon node using just:
nix run 'github:status-im/nimbus-eth2?submodules=1'The
?submodules=1part should eventually not be necessary. For more details see: