Integrate hashtree for better hashing performance
#5188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably that's not available in the git repo, but this error triggers regardless on |
arnetheduck
force-pushed
the
hashtree
branch
2 times, most recently
from
7faf769
to
9632fc7
Compare
arnetheduck
force-pushed
the
hashtree
branch
2 times, most recently
from
5b5972a
to
060937d
Compare
arnetheduck
force-pushed
the
hashtree
branch
2 times, most recently
from
84093c0
to
8d6b7d2
Compare
arnetheduck
changed the title
hashtree for better hashing performance
tersec
reviewed
May 2, 2024
| @@ -136,6 +136,10 @@ jobs: | |||
| fi | |||
| fi | |||
|
|
|||
| if [[ '${{ runner.os }}' == 'Windows' ]]; then | |||
| export NIMFLAGS="${NIMFLAGS} --cc:clang" | |||
| fi | |||
There was a problem hiding this comment.
Does this imply new build requisites for https://nimbus.guide/install.html#build-prerequisites ?
There was a problem hiding this comment.
not really, this is something our ci builds are set up to do explicitly..
There was a problem hiding this comment.
the problem before this line was that clang pretends to be gcc (via executable name) but isn't compatible enough
tersec
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status-im/nim-ssz-serialization#35 brings in https://github.com/prysmaticlabs/hashtree as a supported backend for SHA256, giving a nice little performance boost to all
hash_tree_rootcalls on supported platforms / compilers.Expected gains are on the order of 30% which in the case of a replayed state nets us 0.2-0.3s improvement.
More about this design here: https://hackmd.io/@potuz/BJyrx9DOF - kudos to @potuz for this excellent library!