Static link rocksdb with Nimbus. #2084

web3-developer · 2024-03-19T08:43:01Z

This PR include the following changes:

Update nim-rocksdb to the latest version which includes support for building RocksDb libs from source and static linking.
Make file is updated to support triggering building the RocksDb static library dependencies.
New make target nimbus_rocksdb_static will build nimbus using static linking.
Static linking is disabled by default so the regular make nimbus will continue to use the dynamic library.
Static linking is not supported on windows because RocksDb doesn't support building with Mingw.

…ng using: make nimbus_rocksdb_static

web3-developer requested review from jangko and kdeme March 19, 2024 08:45

web3-developer marked this pull request as ready for review March 27, 2024 06:15

web3-developer added 6 commits March 27, 2024 14:26

Static link rocksdb into Nimbus.

651be3d

Link in additional compression libraries.

09d12aa

Support static linking for MacOS.

47ff224

Add flag to support disabling rocksdb static linking.

9de92c1

Static linking is disabled by default. Build nimbus with static linki…

280b512

…ng using: make nimbus_rocksdb_static

Update nim-rocksdb to latest.

9bb9e3b

web3-developer force-pushed the rocksdb-static-linking branch from dc2c9d6 to 9bb9e3b Compare March 27, 2024 06:26

web3-developer changed the title ~~Static link rocksdb into Nimbus.~~ Static link rocksdb with Nimbus. Mar 27, 2024

web3-developer requested review from jangko and kdeme and removed request for jangko and kdeme March 27, 2024 06:37

jangko approved these changes Mar 27, 2024

View reviewed changes

web3-developer merged commit 0c01418 into master Mar 28, 2024
25 checks passed

web3-developer deleted the rocksdb-static-linking branch March 28, 2024 01:55

Provide feedback