Db namespaces added to newKvt API #2068
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a namespace parameter to the newKvt API. The namespace parameter is a required field and so must be provided. For convenience I've created another proc called newDefaultKvt which will use the default namespace. The older kvt legacy kvt API doesn't have this namespace parameter so we don't need to update all the existing code that uses the older API. Inside the legacy backend the kvtMethods proc checks the namespace and if it is not equal to the default namespace then it adds the prefix byte to the key. This is done to keep the functionality the same while allowing us to change the way we use the newKvt API. When using the new API and setting a non default namespace we should not add the prefix byte before passing in the key.
Currently the legacy database and many of the tests rely on the use of the prefix byte existing in the keys and so it is very difficult to introduce the namespace and remove the byte prefix all at once so I've opted to do the change in smaller steps. This change doesn't yet use the column families in RocksDb, it simply introduces changes to the newKvt API.
Next steps: