Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for namespaces to RocksDb kvstore. #2066

Merged
merged 4 commits into from Mar 12, 2024

Conversation

web3-developer
Copy link
Contributor

@web3-developer web3-developer commented Mar 11, 2024

This PR contains the first part of the namespaces/rockdb column family changes.

Changes in this PR:

  • Refactor/cleanup of the existing RocksStoreRef type.
  • Added new RocksNamespaceRef type.
  • Removed the unused and unneeded db backups feature from the RocksStoreRef and other locations.
  • Removed the usage of the RocksDb readonly option from the RocksStoreRef as it complicates the API and was unused. Also the read only RocksDb instances have some issues to be aware of. Basically when starting a read only db connection the data read is from the point in time when the connection was opened but new updates won't be reflected in that connection. See here: https://github.com/facebook/rocksdb/wiki/Read-only-and-Secondary-instances
  • Bumped nim-rocksdb to the latest version which contains a recent fix to always open the default column family even if it is missing from the column families list.

@web3-developer web3-developer changed the title Db namespaces kvstore Added support for namespaces to RocksDb kvstore. Mar 11, 2024
@web3-developer web3-developer merged commit 799acf3 into master Mar 12, 2024
25 checks passed
@web3-developer web3-developer deleted the db-namespaces-kvstore branch March 12, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants