Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Chore/fix edit account and remove category tests #490

Merged

Conversation

Valentina1133
Copy link
Contributor

@Valentina1133 Valentina1133 commented Feb 7, 2024

CI runs:

Allure reports:
Screenshot 2024-02-07 at 14 43 43

Screenshot 2024-02-07 at 14 36 40

@Valentina1133
Copy link
Contributor Author

I also have a thought that we need to add verifying 5 chars min account keypair name @anastasiyaig after changes from that PR status-im/status-desktop#13414? Maybe as a separate task? Or I can add verifications in this PR

@anastasiyaig
Copy link
Collaborator

I also have a thought that we need to add verifying 5 chars min account keypair name @anastasiyaig after changes from that PR status-im/status-desktop#13414? Maybe as a separate task? Or I can add verifications in this P

can you pls add a task real quick for that? I will ask Magnus to do it as learning exercise

@Valentina1133
Copy link
Contributor Author

I also have a thought that we need to add verifying 5 chars min account keypair name @anastasiyaig after changes from that PR status-im/status-desktop#13414? Maybe as a separate task? Or I can add verifications in this P

can you pls add a task real quick for that? I will ask Magnus to do it as learning exercise

Sure! I will add it now. Great idea!

@Valentina1133
Copy link
Contributor Author

I also have a thought that we need to add verifying 5 chars min account keypair name @anastasiyaig after changes from that PR status-im/status-desktop#13414? Maybe as a separate task? Or I can add verifications in this P

can you pls add a task real quick for that? I will ask Magnus to do it as learning exercise

Sure! I will add it now. Great idea!

#491 - task added

@anastasiyaig anastasiyaig merged commit a5fe297 into master Feb 8, 2024
@anastasiyaig anastasiyaig deleted the chore/fix_edit_account_and_remove_category_tests branch February 8, 2024 07:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test_settings_edit_status_account and test_remove_community_category
2 participants