Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

Fix simulating events on child actors. #326 #348 #347

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

MarianPalkus
Copy link

This PR fixes #326 by searching for child actors when simulating events:

  • adds method findChildService to src/utils.ts to recursively search for child service with the target sessionId
  • start the search for child services if no root service matches the sessionId of the even to process

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2022

⚠️ No Changeset found

Latest commit: a4d9991

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 24, 2022

@MarianPalkus is attempting to deploy a commit to the Stately Team on Vercel.

A member of the Team first needs to authorize it.

@MarianPalkus
Copy link
Author

Might be related to #352.

@Andarist
Copy link
Member

Andarist commented Apr 5, 2022

Could you add an e2e test case for this? It would be way easier to review this with such test case in place

@vercel
Copy link

vercel bot commented Apr 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/statelyai/xstate-viz/92v7KSAVXHzZ9qNA9TgkeUD91x4p
✅ Preview: https://xstate-viz-git-fork-marianpalkus-326fixsimulat-1a4f77-statelyai.vercel.app

@MarianPalkus
Copy link
Author

MarianPalkus commented Apr 5, 2022

Sure, added a test case. I hope it makes sense.

@MarianPalkus
Copy link
Author

MarianPalkus commented Oct 24, 2022

Might be related #348.

@MarianPalkus MarianPalkus changed the title Fix simulating events on child actors. #326 Fix simulating events on child actors. #326 #348 Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants