New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Ability to set max file size on an asset container #9966
Open
edalzell
wants to merge
8
commits into
statamic:5.x
Choose a base branch
from
edalzell:feature/asset-container-file-size-validation
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[5.x] Ability to set max file size on an asset container #9966
edalzell
wants to merge
8
commits into
statamic:5.x
from
edalzell:feature/asset-container-file-size-validation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edalzell
commented
Apr 27, 2024
@@ -17,6 +17,7 @@ public function keys() | |||
'search_index', | |||
'api_url', | |||
'assets', | |||
'max_size', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonvarga I don't understand why this is needed, but without it the tests don't pass. With it, unrelated tests fail.
This works for me, but I'm having some trouble with the tests (see comment above). Guidance/help would be appreciated. |
edalzell
changed the title
[4.x] Ability to set max file size on an asset container
[5.x] Ability to set max file size on an asset container
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes statamic/ideas#1109