Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Add collection title to select field #9749

Open
wants to merge 3 commits into
base: 5.x
Choose a base branch
from
Open

[5.x] Add collection title to select field #9749

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aed0c67
Add collection title to select field
martyf Mar 18, 2024
a1b375b
Add hasMultipleCollections computed property
martyf Mar 18, 2024
fbbfac4
Merge branch '5.x' into pr/9749
duncanmcclean May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion resources/js/components/inputs/relationship/SelectField.vue
View file
Open in desktop
Expand Up @@ -32,7 +32,13 @@
v-bind="attributes"
>
</template>
<template #no-options>
<template #option="option">
<template v-if="hasMultipleCollections">
<span class="text-gray-700 mr-2">{{ option.collection.title }}</span>
</template>
{{ option.title }}
</template>
<template #no-options>
<div class="text-sm text-gray-700 rtl:text-right ltr:text-left py-2 px-4" v-text="__('No options to choose from.')" />
</template>
<template #footer="{ deselect }" v-if="multiple">
Expand Down Expand Up @@ -99,6 +105,10 @@ export default {
},

computed: {
hasMultipleCollections(){
return this.config.collections?.length > 1 || [...new Set(this.options.map(option => option?.collection?.handle))].length > 1;
},

isTaggable() {
if (data_get(this.config, 'create') === false) return false;

Expand Down