Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_played_at filter #4829

Merged
merged 2 commits into from May 14, 2024
Merged

Add last_played_at filter #4829

merged 2 commits into from May 14, 2024

Conversation

NotForMyCV
Copy link
Contributor

Adds the ability to filter scenes by their most recent view, addresses #4659

@NotForMyCV NotForMyCV changed the title Add last_played_at filter (stashapp#4659) Add last_played_at filter May 11, 2024
Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this as-is, but I'm not certain that the null behaviour is correct.

In other cases, we would include explicit is null/not null modifiers, and last played at < date would exclude scenes that have not been played. I'm undecided on what mechanism is more intuitive/has more utility.

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label May 14, 2024
@WithoutPants WithoutPants added this to the Version 0.26.0 milestone May 14, 2024
@WithoutPants WithoutPants merged commit c8aeb79 into stashapp:develop May 14, 2024
2 checks passed
@WithoutPants WithoutPants linked an issue May 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add last_played_at to filters
2 participants