Extend orientation / rotation support for files on load #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterBotSociety
commented
Apr 23, 2024
| @@ -147,7 +147,7 @@ func (f *FFProbe) Path() string { | |||
|
|
|||
| // NewVideoFile runs ffprobe on the given path and returns a VideoFile. | |||
| func (f *FFProbe) NewVideoFile(videoPath string) (*VideoFile, error) { | |||
| args := []string{"-v", "quiet", "-print_format", "json", "-show_format", "-show_streams", "-show_error", videoPath} | |||
| args := []string{"-v", "quiet", "-print_format", "json", "-count_frames", "-show_format", "-show_streams", "-show_entries", "side_data=rotation", "-show_error", videoPath} | |||
There was a problem hiding this comment.
count_frames here is probably not necessary
|
Thank you for fixing this issue, it makes the project even more perfect.🎉 |
zhyu
reviewed
Apr 23, 2024
|
JFYI, this repo contains example images with all possible EXIF orientation values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #4555, #4738, #3479 by adding support to parse out
rotationframe side_data from FFMPEG / ffprobeI manually tested this with a small set of reproducing JPEG images, but have not yet had the chance to try out other image types.
Thanks to @onlyhooops for their repro images, and to @zhyu for calling out the ffprobe tooling.