Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom slider to other grid views #4674

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

cj12312021
Copy link
Collaborator

This pull request brings the zoom slider to the movie, performer, and studio pages. It makes sense to save the state of the zoom index for each page, but to minimize conflicts, it probably makes sense to wait until #4453 is merged.

@cj12312021 cj12312021 changed the title Add zoom slider to other list views Add zoom slider to other grid views Mar 9, 2024
@cj12312021
Copy link
Collaborator Author

Hmm, I was under the impression that the zoom level wasn't stored in saved filters, but that does not seem to be the case. I don't think anything else needs to be done here.

@WithoutPants
Copy link
Collaborator

I can see merit in a zoom slider for movie cards, but is there really a need for zooming of performer and studio cards?

@cj12312021
Copy link
Collaborator Author

I remember Echo specifically requested the zoom slider on the performer page so he could fit more of those cards on his screen https://discord.com/channels/559159668438728723/644934273459290145/1204623730895228989. Everything else was just for consistency.

@cj12312021
Copy link
Collaborator Author

Of the new additions, I’d probably only use the slider to reduce the size of the movie cards. I’m not against removing the slider on the studio page, but with the sliders on all the other pages, it seems like we might as well include it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants