Import video rotation from side_data_list as well #4461
+22
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports rotation info for a video out of the first side_data_list structure if available and if rotate tag is not present.
Fixes #4233 but I'm not sure if the fix is robust enough. It works on all my affected files.
One issue left unsolved is that once a file has been added to the DB with the wrong rotation info then it is impossible to fix it short of directly editing the DB.
If I remove the scene without deleting the scene file then the file row in the DB is not removed so the rotation information is not removed either.
Ideally a rescan should reimport the rotation info but I couldn't figure out how to do that.