Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building stash without CGo (using modernc.org/sqlite as option) #4106

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

its-josh4
Copy link
Contributor

@its-josh4 its-josh4 commented Sep 11, 2023

Fixes #4103

  • Can compile without CGo by using CGO_ENABLED=0 before make. e.g. CGO_ENABLED=0 make build
  • Adds modernc.org/sqlite as a SQLite driver when CGo is not available. If stash is compiled with CGo available, the existing sqlite driver is used.
  • systray is not enabled if CGo is disabled

its-josh4 added a commit to its-josh4/stash that referenced this pull request Sep 11, 2023
Includes some dependencies that were upgraded in stashapp#4106 as well as a few more dependencies.

Notably, removes deprecated dependencies such as `github.com/go-chi/chi` (replaced with `/v5`), and upgrades some deps that had CVEs.
its-josh4 added a commit to its-josh4/stash that referenced this pull request Sep 11, 2023
Includes some dependencies that were upgraded in stashapp#4106 as well as a few more dependencies.

Some deps that have been upgraded had CVEs.

Notably, upgrades deprecated dependencies such as:
- `github.com/go-chi/chi` (replaced with `/v5`)
- `github.com/gofrs/uuid` (replaced with `/v5`)
- `github.com/hashicorp/golang-lru` (replaced with `/v2` which uses generics)
@its-josh4 its-josh4 changed the title WIP: Allow building stash without CGo (using modernc.org/sqlite as option) Allow building stash without CGo (using modernc.org/sqlite as option) Oct 22, 2023
@its-josh4 its-josh4 marked this pull request as ready for review October 22, 2023 20:26
its-josh4 added a commit to its-josh4/stash that referenced this pull request Oct 22, 2023
WithoutPants pushed a commit that referenced this pull request Oct 22, 2023
WithoutPants pushed a commit that referenced this pull request Oct 26, 2023
* Update a number of dependencies (incl. CVE fixes)

Includes some dependencies that were upgraded in #4106 as well as a few more dependencies.

Some deps that have been upgraded had CVEs.

Notably, upgrades deprecated dependencies such as:
- `github.com/go-chi/chi` (replaced with `/v5`)
- `github.com/gofrs/uuid` (replaced with `/v5`)
- `github.com/hashicorp/golang-lru` (replaced with `/v2` which uses generics)

* Upgraded a few more deps

* lint

* reverted yaml library to v2

* remove unnecessary mod replace

* Update chromedp

Fixes #3733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Make it possible to statically compile binary (disable CGo)
2 participants