Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Some images have the wrong proportions on image wall #4555

Open
onlyhooops opened this issue Feb 13, 2024 · 6 comments · May be fixed by #4781
Open

[Bug Report] Some images have the wrong proportions on image wall #4555

onlyhooops opened this issue Feb 13, 2024 · 6 comments · May be fixed by #4781
Labels
bug report Bug reports that are not yet verified

Comments

@onlyhooops
Copy link

Describe the bug
I use Synology NAS 923+ and deploy Stash via Docker.

When adding large image files (photos taken with a DSLR camera, for example) using Stash, the thumbnails displayed in image wall mode do not have the correct proportions.

Expected behavior
It seems that "stash" is unable to generate thumbnails with correct proportions for specific image files or is unable to display thumbnails correctly in the photo wall view.

Screenshots
22222
111
photo metadata
exiftool.txt

@onlyhooops onlyhooops added the bug report Bug reports that are not yet verified label Feb 13, 2024
@onlyhooops
Copy link
Author

@WithoutPants WithoutPants changed the title [Bug Report] Image wall view error [Bug Report] Some images have the wrong proportions on image wall Feb 13, 2024
@onlyhooops
Copy link
Author

My tests have revealed that whether running Stash on Docker, or directly on Linux, macOS, or Windows, the thumbnail aspect ratios are incorrect in the photo wall mode when adding photos taken with Nikon DSLR cameras. There is no such issue with photos from other brands like Canon or Sony (though the testing might not have been exhaustive).

@onlyhooops
Copy link
Author

I would greatly appreciate it if the developers could address and resolve this bug.

@OtterBotSociety
Copy link

OtterBotSociety commented Apr 16, 2024

The proportion seems to be correct, but with the wrong width and height ascribed by the backend.
With the ID 5868 mapped to one of the sample images, the following query:

query {
  findImage(id: 5868) {
    ... on Image {
      id
      visual_files {
        ... on ImageFile {
          path
          height
        	width
        }
      }
    }
  }
}

returns the following value:

{
  "data": {
    "findImage": {
      "id": "5868",
      "visual_files": [
        {
          "path": "D:\\Backups\\DSC_0052.jpg",
          "height": 5504,
          "width": 8256
        }
      ]
    }
  }
}

I suspect this has to do with the non-zero orientation in the EXIF metadata:

Exif Image Width                : 8256
Exif Image Height               : 5504
...
Orientation                     : Rotate 270 CW

@OtterBotSociety
Copy link

OtterBotSociety commented Apr 16, 2024

This seems to happen for other kinds of images, as well. In particular, I'm noticing a lot of animated webps reporting (via the same graphql query) a height and width of 0, leading to react-photo-gallery using their native width, and filling the row's height -- making for some very awkward-ly stretched images.

@OtterBotSociety
Copy link

possibly duplicated in #4738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: To triage
Development

Successfully merging a pull request may close this issue.

2 participants