Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Rotation information is ignored for determining if a video is portrait #4233

Open
puc9 opened this issue Oct 20, 2023 · 0 comments · May be fixed by #4461
Open

[Bug Report] Rotation information is ignored for determining if a video is portrait #4233

puc9 opened this issue Oct 20, 2023 · 0 comments · May be fixed by #4461
Labels
bug report Bug reports that are not yet verified

Comments

@puc9
Copy link
Contributor

puc9 commented Oct 20, 2023

Describe the bug
A portrait clip recorded on an iPhone will be stored as landscape but with rotation information embedded.
The clip plays fine and everything work except for the scene cards that do not get the css class portrait.

Relevant ffprobe output:

Stream #0:0[0x1](und): Video: hevc (Main) (hvc1 / 0x31637668), yuv420p(tv, bt709), 3840x2160
...
Metadata:
  creation_time   : xxxxx
  handler_name    : Core Media Video
  vendor_id       : [0][0][0][0]
  encoder         : HEVC
Side data:
  displaymatrix: rotation of -90.00 degrees

To Reproduce
Steps to reproduce the behavior:

  1. Record a clip vertically with an iPhone
  2. Scan it
  3. The thumbnail and the video preview in the scene card will only show the top part of the image.
  4. The scrubber in the scene card will show the whole image as expected

Somewhat related to this:

  1. For portrait mode clips the scrubber in the player page only shows the upper side of the image.
  2. For portrait mode clips that have landscape thumbnails (think a short clip from yt downloaded with yt-dlp) the video preview is taller than the thumbnail. To fix it I had to disable making the portrait mode taller by adding the custom css (only for zoom-1, since that is what I use):
.zoom-1 .portrait {
  height: 180px;
}

Expected behavior
The way the scrubber looks on the scene card is the way that the portrait thumbnail and video preview should look like on the scene card.

Stash Version: (from Settings -> About):
Few days old custom build

@puc9 puc9 added the bug report Bug reports that are not yet verified label Oct 20, 2023
@puc9 puc9 linked a pull request Jan 16, 2024 that will close this issue
@WithoutPants WithoutPants modified the milestone: Version 0.25.0 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: To triage
Development

Successfully merging a pull request may close this issue.

2 participants