Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced from tqdm import tqdm with from tqdm.auto import tqdm #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajinkya-kulkarni
Copy link
Contributor

Consistent UI across platforms for tqdm

@uschmidt83
Copy link
Member

Hi @ajinkya-kulkarni, I agree that tqdm.auto loads a nicer progress bar in Jupyter notebooks, but it also has the disadvantage that the progress bar isn't preserved in the notebook output. I.e. one cannot see how many iterations / long it took when the notebook isn't "live" anymore. Or has this recently changed?

@ajinkya-kulkarni
Copy link
Contributor Author

Hi @uschmidt83, no I don't have this problem - do you have a minimal example, which I reproduce?

@uschmidt83
Copy link
Member

  1. Running the code in a "live" notebook:
    image

  2. Kernel > Shutdown
    image

  3. Saving the notebook and reloading the webpage:
    image

@ajinkya-kulkarni
Copy link
Contributor Author

Oh, that's why you mean! Sorry, I had misunderstood your question earlier then.
Yes, that looks like a drawback, but I don't know if preserving the tqdm output is important. I think its okay if it is not preserved.

@uschmidt83
Copy link
Member

Yes, that looks like a drawback, but I don't know if preserving the tqdm output is important. I think its okay if it is not preserved.

I think it's important for our example notebooks, so that people know how long they can expect certain tasks to run.

@ajinkya-kulkarni
Copy link
Contributor Author

Alright - then let#s wait until the issue is fixed from the 'tqdm' end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants