-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: enhancement-322-Add-retry-mechanism-for-the-given-error #323
base: master
Are you sure you want to change the base?
draft: enhancement-322-Add-retry-mechanism-for-the-given-error #323
Conversation
14557b0
to
6929e02
Compare
sql: str, | ||
auto_begin: bool = False, | ||
fetch: bool = False, | ||
max_retries=trino.constants.DEFAULT_MAX_ATTEMPTS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trino.constants.DEFAULT_MAX_ATTEMPTS
is for connection timeout issues
auto_begin: bool = False, | ||
fetch: bool = False, | ||
max_retries=trino.constants.DEFAULT_MAX_ATTEMPTS, | ||
retry_delay: int = 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dataders can we pass a specific error message, retry_delay and max_retries from model configuration to here?
I have created a dbt-core issue that is probably relevant: dbt-labs/dbt-adapters#226 |
Overview
resolves #322
Checklist
README.md
updated and added information about my changechangie new
to create a changelog entry