Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datastore): support backup and restore #3119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jan 9, 2024

Description

TODO: prevent race condition issues in the datastore during operations.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft January 9, 2024 10:14
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (cd671cb) 91.60% compared to head (10c01c2) 82.81%.
Report is 2 commits behind head on main.

Files Patch % Lines
...tarwhale/mlops/datastore/backup/BackupManager.java 82.35% 22 Missing and 14 partials ⚠️
...va/ai/starwhale/mlops/api/DataStoreController.java 0.00% 19 Missing ⚠️
...java/ai/starwhale/mlops/datastore/backup/Meta.java 25.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3119      +/-   ##
============================================
- Coverage     91.60%   82.81%   -8.79%     
- Complexity        0     3224    +3224     
============================================
  Files           142      577     +435     
  Lines         16442    32335   +15893     
  Branches         61     1899    +1838     
============================================
+ Hits          15062    26779   +11717     
- Misses         1378     4715    +3337     
- Partials          2      841     +839     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller 73.45% <73.81%> (?)
standalone 92.11% <100.00%> (+0.25%) ⬆️
unittests 91.85% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui force-pushed the datastore-backup branch 3 times, most recently from 2fb055a to 7383f60 Compare January 11, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant