Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(datastore): support deleting by key range or prefix #3103

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

jialeicui
Copy link
Contributor

Description

depends on #3093

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (cf58e90) 82.68% compared to head (3cc5218) 82.73%.
Report is 4 commits behind head on main.

Files Patch % Lines
...tarwhale/mlops/datastore/impl/MemoryTableImpl.java 89.83% 6 Missing and 12 partials ⚠️
...n/java/ai/starwhale/mlops/datastore/DataStore.java 56.25% 13 Missing and 1 partial ⚠️
...n/java/ai/starwhale/mlops/datastore/Tombstone.java 82.05% 2 Missing and 5 partials ⚠️
.../starwhale/mlops/datastore/impl/RecordDecoder.java 0.00% 5 Missing ⚠️
...va/ai/starwhale/mlops/api/DataStoreController.java 87.50% 1 Missing ⚠️
.../java/ai/starwhale/mlops/datastore/Checkpoint.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3103      +/-   ##
============================================
+ Coverage     82.68%   82.73%   +0.05%     
- Complexity     3182     3263      +81     
============================================
  Files           573      578       +5     
  Lines         31969    32359     +390     
  Branches       1865     1916      +51     
============================================
+ Hits          26433    26773     +340     
- Misses         4712     4740      +28     
- Partials        824      846      +22     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller 73.55% <83.85%> (+0.18%) ⬆️
standalone 91.88% <100.00%> (+0.02%) ⬆️
unittests 91.62% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui marked this pull request as draft January 3, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant