Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): support checkpoint in remote datastore #3099

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft December 27, 2023 07:52
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (b7524b5) 82.68% compared to head (b543052) 91.88%.
Report is 1 commits behind head on main.

Files Patch % Lines
client/starwhale/api/_impl/data_store.py 54.54% 5 Missing ⚠️
client/starwhale/base/client/api/data_store.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3099      +/-   ##
============================================
+ Coverage     82.68%   91.88%   +9.19%     
============================================
  Files           573      138     -435     
  Lines         31970    16160   -15810     
  Branches       1865        0    -1865     
============================================
- Hits          26435    14848   -11587     
+ Misses         4709     1312    -3397     
+ Partials        826        0     -826     
Flag Coverage Δ
console ?
controller ?
standalone 91.88% <80.48%> (-0.01%) ⬇️
unittests 91.88% <80.48%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant