Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): prevent dirty git workspace after yarn install #3096

Merged
merged 6 commits into from Dec 25, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Dec 25, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7524b5) 82.68% compared to head (06d682e) 91.59%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3096      +/-   ##
============================================
+ Coverage     82.68%   91.59%   +8.91%     
============================================
  Files           573      140     -433     
  Lines         31970    16341   -15629     
  Branches       1865       61    -1804     
============================================
- Hits          26435    14968   -11467     
+ Misses         4709     1371    -3338     
+ Partials        826        2     -824     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller ?
standalone 91.85% <ø> (-0.03%) ⬇️
unittests 91.59% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui added bug 🐛 Something isn't working ci 🕹️ labels Dec 25, 2023
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 1818226 into star-whale:main Dec 25, 2023
38 checks passed
@jialeicui jialeicui deleted the fix-yarn-lock branch December 25, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working ci 🕹️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants