Add --verbose-version (-V) flag #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the second feature mentioned in standardrb#452. For context, when debugging a RuboCop issue a user is asked to supply the output of `rubocop -V`, and this streamlines this process for standard users.
| def call(command) | ||
| require_relative "runners/#{command}" | ||
| ::Standard::Runners.const_get(command.to_s.capitalize).new |
There was a problem hiding this comment.
This meta-programming doesn't work with multiple-word command/constants (for example :verbose_version/VerboseVersion). Instead of modifying to account for this edge-case, I swapped out the code for a HashTable lookup. Less fun, I know. 😢
|
Seems fine to me |
|
@camilopayan merge if LGTU? |
|
@camilopayan just updated branch from main if you want to take a look! |
|
@patrickbrown-dev should the |
|
@saturnflyer nope, that's on me! |
|
@saturnflyer |
|
LGTM! Love when I see a PR and don't feel like I need to pull it down to test it locally before merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the second feature mentioned in #452. For context, when debugging a RuboCop issue a user is asked to supply the output of
rubocop -V, and this streamlines this process for standard users.