New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add check for whether account is deployed #83

Open

SilasZhr wants to merge 1 commit into stackup-wallet:main from SilasZhr:fix/initCodeIssue

SilasZhr commented Jul 26, 2023 •

edited

What?

This PR updates both simpleAccount.ts and gasLimit.ts with initCode issue.

Why?

There is an issue when I want to send the first UO if I've deployed account proxy by calling senderCreator or AccountFactory.
It always checks the nonce in EntryPoint in Here. But I think user should be able to use EntryPoint with deployed account.

How?

check the account code instead of ctx.op.nonce when setting initCode for UO
check initCode length before getting factory address from initCode, and return zero for CreationGas if initCode is 0x

Testing?

Passed


          fix: Add check for whether account is deployed

671bfac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment