Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: core contract tests corrupted package.json #4594

Merged
merged 2 commits into from Mar 26, 2024

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Mar 26, 2024

Description

  • Fix broken CI
  • Because the clarinet-sdk 2.4.0 was release as stable, the -f isn't needed anymore
    I'll try to see how the lock file got corrupted in the first place

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI finishes. Thanks for the quick fix @hugocaillard ! :shipit:

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward having this merged on next so we can then pull it in #4550. 💯

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.24%. Comparing base (aaab6bc) to head (cff2e7d).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4594      +/-   ##
==========================================
- Coverage   86.09%   78.24%   -7.86%     
==========================================
  Files         466      466              
  Lines      336699   336699              
==========================================
- Hits       289873   263436   -26437     
- Misses      46826    73263   +26437     

see 205 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaab6bc...cff2e7d. Read the comment docs.

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CharlieC3 CharlieC3 added this pull request to the merge queue Mar 26, 2024
Merged via the queue into next with commit d0df9d1 Mar 26, 2024
1 check failed
@hugocaillard hugocaillard deleted the fix/contrib-tests-corrupted-package-lock branch March 28, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants