Add allow-contract-caller command #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowTiedRadone
changed the base branch from
master
to
feat/pox-4-stateful-property-testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/pox-4-stateful-property-testing #4589 +/- ##
========================================================================
+ Coverage 83.38% 83.53% +0.14%
========================================================================
Files 471 448 -23
Lines 337958 327197 -10761
Branches 317 0 -317
========================================================================
- Hits 281809 273317 -8492
+ Misses 56141 53880 -2261
+ Partials 8 0 -8 see 125 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This change optimizes the generation of Clarity values for the allowUntilBurnHt property in the AllowContractCallerCommand tests. By directly creating Clarity optional values (none or some(uint)) within the fast-check generator, we remove the need for conditional post-processing. This approach simplifies the test setup and aligns more closely with the intended usage patterns of the Clarity and fast-check libraries.
- Moved `network` from `Stub` (Model) to `Real`, streamlining state management. - `unlockBurnHt` now dynamically calculated, passed via constructor, ensuring alignment with generated `period`. - Utilized `fast-check`'s `chain` for dynamic `unlockBurnHt` calculation, improving test accuracy. - Enforces discipline in constructor use and `check` method validation, highlighting the importance of explicit state and parameter handling for reliable testing.
moodmosaic
force-pushed
the
feat/pox-4-stateful-allow-contract-caller
branch
from
3e54c0c
to
51a3181
Compare
|
Merging into |
moodmosaic
merged commit d55fc62
into
feat/pox-4-stateful-property-testing
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
allow-contract-callercommand to the stateful property testing environment. It is part of #4548 and targetsfeat/pox-4-stateful-property-testing(#4550).