Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revoke-delegate-stx command #4581

Conversation

BowTiedRadone
Copy link
Contributor

This PR adds the revoke-delegate-stx command to the stateful property testing environment.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.30%. Comparing base (d6047eb) to head (39b9a3c).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           feat/pox-4-stateful-property-testing    #4581       +/-   ##
=========================================================================
+ Coverage                                 71.28%   83.30%   +12.02%     
=========================================================================
  Files                                       456      453        -3     
  Lines                                    331024   328491     -2533     
  Branches                                    317      323        +6     
=========================================================================
+ Hits                                     235958   273655    +37697     
+ Misses                                    95058    54828    -40230     
  Partials                                      8        8               

see 247 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6047eb...39b9a3c. Read the comment docs.

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moodmosaic moodmosaic force-pushed the feat/pox-4-stateful-revoke-delegate-command branch from 39b9a3c to 4d94cbc Compare March 23, 2024 08:38
@moodmosaic
Copy link
Member

This pull request targets #4550 and adds the ability to call revoke-delegate-stx from the stateful property-based tests. Merging into feat/pox-4-stateful-property-testing branch.

@moodmosaic moodmosaic merged commit 1166268 into feat/pox-4-stateful-property-testing Mar 23, 2024
1 check passed
@moodmosaic moodmosaic deleted the feat/pox-4-stateful-revoke-delegate-command branch March 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants