[DRAFT] [pox-4] Stacking stateful property-based tests - DelegateStackStxCommand #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/pox-4-stateful-property-testing #4564 +/- ##
========================================================================
+ Coverage 82.68% 83.31% +0.62%
========================================================================
Files 453 453
Lines 328491 328491
Branches 323 323
========================================================================
+ Hits 271600 273669 +2069
+ Misses 56883 54814 -2069
Partials 8 8 see 37 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
moodmosaic
commented
Mar 20, 2024
contrib/core-contract-tests/tests/pox-4/pox_DelegateStackStxCommand.ts
Outdated
Show resolved
Hide resolved
contrib/core-contract-tests/tests/pox-4/pox_DelegateStackStxCommand.ts
Outdated
Show resolved
Hide resolved
contrib/core-contract-tests/tests/pox-4/pox_DelegateStackStxCommand.ts
Outdated
Show resolved
Hide resolved
moodmosaic
commented
Mar 21, 2024
contrib/core-contract-tests/tests/pox-4/pox-4.stateful-prop.test.ts
Outdated
Show resolved
Hide resolved
moodmosaic
commented
Mar 21, 2024
friedger
approved these changes
Mar 21, 2024
contrib/core-contract-tests/tests/pox-4/pox-4.stateful-prop.test.ts
Outdated
Show resolved
Hide resolved
contrib/core-contract-tests/tests/pox-4/pox_DelegateStackStxCommand.ts
Outdated
Show resolved
Hide resolved
contrib/core-contract-tests/tests/pox-4/pox_DelegateStackStxCommand.ts
Outdated
Show resolved
Hide resolved
| @@ -66,6 +66,9 @@ describe("PoX-4 invariant tests", () => { | |||
| isStacking: false, | |||
| hasDelegated: false, | |||
| delegatedTo: "", | |||
| wasDelegated: false, | |||
| wasDelegatedBy: [], | |||
There was a problem hiding this comment.
To continue the flow, the operator wallet should have a property like hasLocked on successful delegate-stack-stx call.
There was a problem hiding this comment.
Thanks. I kept a note in the base branch/PR: https://github.com/stacks-network/stacks-core/pull/4550/files#r1536597708
Add: generated amount for DelegateStackStx Add: generator limits for startBurnHt using Simnet Fix: address `hasPoolMembers`, `stacker balance check` comments Fix: command descriptions Add: amount generator for DelegateStx; Fix: command logs
moodmosaic
force-pushed
the
feat/pox-4-stateful-property-testing-delegate
branch
from
f8d274e
to
a7f7e9f
Compare
moodmosaic
merged commit fe1b3af
into
feat/pox-4-stateful-property-testing
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request targets #4550 and adds the ability to call
delegate-stacks-stxfrom the stateful property-based tests.