Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: upgrade core-contract-tests dependencies #4528

Merged
merged 3 commits into from Mar 14, 2024

Conversation

hugocaillard
Copy link
Collaborator

Upgrade npm dependencies of core-contract-tests

  • vite and vitests to v1, no big impact impacts vs the previous version. Require slight changes in vitest.config file
  • clarinet-sdk upgraded to the latest beta, it now uses deployment-plans, hence the new file

moodmosaic
moodmosaic previously approved these changes Mar 13, 2024
Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.29%. Comparing base (fec1cb5) to head (b3ae5c5).
Report is 8 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4528      +/-   ##
==========================================
- Coverage   83.32%   83.29%   -0.03%     
==========================================
  Files         453      453              
  Lines      327368   327368              
  Branches      323      323              
==========================================
- Hits       272780   272689      -91     
- Misses      54580    54671      +91     
  Partials        8        8              

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec1cb5...b3ae5c5. Read the comment docs.

@moodmosaic moodmosaic force-pushed the tests/upgrade-core-contract-tests-dependencies branch from 48f26ff to b3ae5c5 Compare March 13, 2024 16:24
Copy link
Collaborator

@friedger friedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saralab saralab requested a review from obycode March 14, 2024 15:46
@wileyj wileyj enabled auto-merge March 14, 2024 22:32
@wileyj wileyj added this pull request to the merge queue Mar 14, 2024
Merged via the queue into next with commit 3adb6ed Mar 14, 2024
2 checks passed
@hugocaillard hugocaillard deleted the tests/upgrade-core-contract-tests-dependencies branch March 15, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants