Add optional fuel tracking for wasm execution #371
+405
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably add a different error type to better handle out of fuel errors |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
==========================================
- Coverage 87.15% 86.84% -0.32%
==========================================
Files 43 43
Lines 18510 18064 -446
Branches 18510 18064 -446
==========================================
- Hits 16132 15687 -445
+ Misses 1048 1045 -3
- Partials 1330 1332 +2 ☔ View full report in Codecov by Sentry. |
Acaccia
reviewed
Mar 21, 2024
clar2wasm/src/tools.rs
Outdated
|
|
||
| assert!(env.evaluate("(+ 1 2)").is_err()); | ||
|
|
||
| let mut env = TestEnvironment::new(StacksEpochId::latest(), ClarityVersion::latest(), Some(90)); |
There was a problem hiding this comment.
trial and error, setting the limits will require a similar process
obycode
previously approved these changes
Mar 26, 2024
clar2wasm/src/tools.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| //! The `tools` module contains tools for evaluating Clarity snippets. | |||
| //! THE `tools` module contains tools for evaluating Clarity snippets. | |||
|
Does the fuel mechanism have any impact on the execution time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuel tracking based on wasmtime for limiting execution