Check that string probe port match container port #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
requested changes
Nov 28, 2022
| Parameters: params.ParamDescs, | ||
| ParseAndValidateParams: params.ParseAndValidate, | ||
| Instantiate: params.WrapInstantiateFunc(func(_ params.Params) (check.Func, error) { | ||
| return util.PerNonInitContainerCheck(func(container *v1.Container) []diagnostic.Diagnostic { |
There was a problem hiding this comment.
It will be great if you extract this to a named function and add unit tests to check all code paths.
dhaus67
reviewed
Nov 28, 2022
|
@jouve You need to regenerate files |
|
I'll update this PR soon :) |
|
@jouve ping |
|
@jouve Could you rebase? I think we can make it into next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of #455
if a probe port is a string and the string is not of number (like
"1234") and the string is not in the container ports (ie. ` ports[].name), then raise a diagnostic message.while the resource it accepted by kube currently, the liveness/readiness/startup will fail anyway, so added to default checks.