Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 6 and PHPUnit 9. #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

longwave
Copy link

@longwave longwave commented Jan 17, 2022

Drupal uses stack/builder and so we need to add Symfony 6 compatibility here for us to be able to upgrade.

Locally the tests pass for me with these changes:

$ vendor/bin/phpunit
PHPUnit 9.5.11 by Sebastian Bergmann and contributors.

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

...............                                                   15 / 15 (100%)

Time: 00:00.021, Memory: 8.00 MB

OK (15 tests, 22 assertions)

However the new return type in StackedHttpKernel::handle() might mean this has to be a 2.0 release?

@catch56 catch56 mentioned this pull request Jan 17, 2022
@fabpot
Copy link
Contributor

fabpot commented Jan 17, 2022

It has to be a 2.0 release indeed.
But I would strongly recommend stopping using this and replacing it with standard Symfony classes instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants