Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rados gateway (dependency for Ironic agent_* drivers) #120

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mateusz-blaszkowski
Copy link
Contributor

No description provided.

@Quentin-M
Copy link
Collaborator

If it's for Ironic only, put its deployment behind an ironic: enabled feature flag so it doesn't get deployed if Ironic is disabled.

nova_pool: "vms"
# Random uuid used for Nova / Cinder communication.
# Should not be modified after the initial deployment.
secret_uuid: bbc5b4d5-6fca-407d-807d-06a4f4a7bccb

rgw:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not expose this block in the main configuration file if configuring these values isn't really that useful for the end-user - to avoid creating confusion and overhead. It looks more like internal parameters to me? Instead, we should be sure to have sensitive/matching defaults in both packages that use them.

@@ -54,11 +54,18 @@ ceph:
glance_user: "glance"
glance_pool: "images"
glance_keyring: ""
rgw_user: "ironic"
admin_keyring: ""
Copy link
Collaborator

@Quentin-M Quentin-M Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put these two below secret_uuid and comment that it is only needed for Ironic and shouldn't be provided otherwise. Therefore users who don't want/need Ironic won't have to / be scared of giving away their admin key.

@mateusz-blaszkowski
Copy link
Contributor Author

mateusz-blaszkowski commented Oct 21, 2016

@Quentin-M I'll put rgw behind ironic: enabled flag in Ironic PR (#93). I also plan to add Ironic section into README and describe the usage of RGW there.

Signed-off-by: Mateusz Blaszkowski <mateusz.blaszkowski@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants