-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rados gateway (dependency for Ironic agent_* drivers) #120
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mateusz Blaszkowski <mateusz.blaszkowski@intel.com>
If it's for Ironic only, put its deployment behind an |
nova_pool: "vms" | ||
# Random uuid used for Nova / Cinder communication. | ||
# Should not be modified after the initial deployment. | ||
secret_uuid: bbc5b4d5-6fca-407d-807d-06a4f4a7bccb | ||
|
||
rgw: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not expose this block in the main configuration file if configuring these values isn't really that useful for the end-user - to avoid creating confusion and overhead. It looks more like internal parameters to me? Instead, we should be sure to have sensitive/matching defaults in both packages that use them.
@@ -54,11 +54,18 @@ ceph: | |||
glance_user: "glance" | |||
glance_pool: "images" | |||
glance_keyring: "" | |||
rgw_user: "ironic" | |||
admin_keyring: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put these two below secret_uuid
and comment that it is only needed for Ironic and shouldn't be provided otherwise. Therefore users who don't want/need Ironic won't have to / be scared of giving away their admin key.
@Quentin-M I'll put rgw behind |
Signed-off-by: Mateusz Blaszkowski <mateusz.blaszkowski@intel.com>
No description provided.