Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of Pinocchio 2.7.0 into ROS 2 Rolling (and possibly Jazzy) #2227

Open
clalancette opened this issue Apr 25, 2024 · 3 comments
Open
Assignees

Comments

@clalancette
Copy link

Currently pinocchio is failing to build on ROS 2 Rolling: https://build.ros2.org/job/Rsrc_uN__pinocchio__ubuntu_noble__source/ .

The easiest solution to this problem is to do a new release of pinocchio into ROS 2 Rolling using bloom-release, which should bump the version to 2.7.0.

If you want, you can also do a release of pinocchio 2.7.0 into Jazzy; that is completely up to you.

Please let me know if you have any questions.

@nim65s
Copy link
Contributor

nim65s commented Apr 25, 2024

@clalancette thanks for stepping into this !

And sorry for not fixing this sooner.

Could you point me to a way to test a release before just running bloom to open a PR ? I have been "just running bloom" a couple time on pinocchio and its dependencies (eigenpy & hpp-fcl), but this is not working better.

For ROS1 (we also have broken packages on noetic), I was using prerelease.ros.org, which was allowing me to fix the ROS patches before opening the PR, but I can't anymore: ros-infrastructure/prerelease_website#65

@clalancette
Copy link
Author

Could you point me to a way to test a release before just running bloom to open a PR ? I have been "just running bloom" a couple time on pinocchio and its dependencies (eigenpy & hpp-fcl), but this is not working better.

Yeah, unfortunately there isn't currently an easy way. In theory it is possible to do a pre-release type thing following the instructions in https://www.youtube.com/watch?v=XA20_iRBLrg , but I have no idea how well that works anymore.

I'll suggest just doing a bloom-release, and seeing what happens. Totally understood that it isn't the most efficient way, but it is the best I can offer for now.

@nim65s
Copy link
Contributor

nim65s commented Apr 26, 2024

Thanks, I will follow your suggestion asap, and look at those instructions after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants