Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin urllib3 in dev dependencies #517

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jsignell
Copy link
Member

Related Issue(s):

Description:
See if unpinning works now that some time has passed.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@jsignell jsignell marked this pull request as draft May 15, 2023 14:18
@jsignell
Copy link
Member Author

Doesn't pass yet.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2398500) 88.34% compared to head (c2717b4) 88.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files          13       13           
  Lines         987      987           
=======================================
  Hits          872      872           
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski changed the title Unpin urllib3 Unpin urllib3 in dev dependencies Jun 7, 2023
@gadomski gadomski linked an issue Aug 21, 2023 that may be closed by this pull request
@gadomski
Copy link
Member

Still no 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urllib3 release breaks tests
3 participants