Java 13 support #241
Open
Java 13 support #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frecco75
force-pushed
the
feat/java13-support
branch
from
c97b81c
to
c2f509e
Compare
sta-szek
reviewed
Jun 8, 2020
| @@ -125,10 +119,6 @@ pitest { | |||
| outputFormats = ['XML', 'HTML'] | |||
| } | |||
|
|
|||
| task wrapper(type: Wrapper) { | |||
| @@ -108,8 +104,6 @@ afterEvaluate { | |||
| task junit5CodeCoverageReport(type: JacocoReport) { | |||
| executionData junitPlatformTest | |||
| sourceSets sourceSets.main | |||
| sourceDirectories = files(project.sourceSets.main.allSource.srcDirs) | |||
| @@ -34,12 +33,6 @@ apply plugin: 'jacoco' | |||
| apply plugin: 'org.junit.platform.gradle.plugin' | |||
| apply plugin: 'maven-publish' | |||
|
|
|||
| buildScan { | |||
| licenseAgreementUrl = 'https://gradle.com/terms-of-service' | |||
| licenseAgree = 'yes' | |||
There was a problem hiding this comment.
why removed?
it was required for bintray in order to release lib to repository
| gradleEnterprise { | ||
| buildScan { | ||
| termsOfServiceUrl = 'https://gradle.com/terms-of-service' | ||
| termsOfServiceAgree = 'yes' |
src/test/java/pl/pojo/tester/internal/field/primitive/AbstractPrimitiveValueChangerTest.java
Show resolved
Hide resolved
| } catch (IllegalAccessException | NoSuchFieldException e) { | ||
| throw new GetOrSetValueException(MODIFIERS_FIELD_NAME_IN_FIELD_CLASS, clazz, e); | ||
| } | ||
| field.setAccessible(true); |
There was a problem hiding this comment.
i guess it is worth to surround with that try/catch anyway.
it is part of logic to throw throw new GetOrSetValueException(MODIFIERS_FIELD_NAME_IN_FIELD_CLASS, clazz, e); if smth goes wrong here.
right now i cannot recall why such implementation was done, but i remember that field.setAccessible(true); was not enough.
cant it be that you will adjust to java 13 and at the same time it will not work for java 8 anymore?
There was a problem hiding this comment.
Yes we need to try with Java8 for safety.
I think your code was probably for final attributes, when we try to make them accessible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding to the issue #239, this is a PR for JDK 13 support.