Skip to content
This repository has been archived by the owner on Jun 10, 2018. It is now read-only.

Add Travis CI tests #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

junaruga
Copy link

@junaruga junaruga commented Apr 4, 2017

Hello @sstephenson ,
I send a pull-request to use Travis CI.
ejs is used a development dependency of sprockets that is used as a part of Rails.
So, it is important for me to maintain this package.

I added ruby-head as allow_failures.
I think this is useful.
Because we can prepare before next version Ruby 2.5 release.
Though it might not be useful until the actual preview release.
We can support the next version as faster.

We can see this kind of logic in rails, rspec and cucumber and etc.
I think that is the reason why rails and rspec can support new version Ruby as faster.

https://github.com/rails/rails/blob/master/.travis.yml
https://github.com/rspec/rspec-core/blob/master/.travis.yml
https://github.com/cucumber/cucumber-ruby/blob/master/.travis.yml

fast_finish is to get the Travis result as faster without waiting the result of the "allow_failures" items.
See https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/

Is it possible to activate this repo's Travis at first?
https://travis-ci.org/sstephenson/ruby-ejs

Thanks.

* Add a list of Ruby.
* Add ruby-head as allow_failures.
  * allow_failures is because it's good to know new version Ruby's issue
    as faster before the release.
  * fast_finish is to get the Travis result as faster
    without waiting the result of the "allow_failures" items.
    See https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
@junaruga
Copy link
Author

junaruga commented Apr 4, 2017

I passed my local test.

$ ruby -v
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]

$ bundle install --path vendor/bundle

$ bundle list
Gems included by the bundle:
  * bundler (1.14.6)
  * ejs (1.1.1)
  * execjs (0.4.0)
  * multi_json (1.12.1)
  * power_assert (1.0.1)
  * rake (12.0.0)
  * test-unit (3.2.3)

$ bundle exec rake
...
22 tests, 35 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@junaruga
Copy link
Author

ping @sstephenson :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant