Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cacheTo Function/container prop #3722

Merged
merged 2 commits into from Apr 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilled-laws-push.md
@@ -0,0 +1,5 @@
---
"sst": patch
---

Fix cacheTo Function/container prop
4 changes: 2 additions & 2 deletions packages/sst/src/constructs/Service.ts
Expand Up @@ -1293,8 +1293,8 @@ export class Service extends Construct implements SSTConstruct {
([pk, pv]) => `${pk}=${pv}`
)
: []
).join(","),
],
)
].join(","),,
]
: []),
this.props.path,
Expand Down
8 changes: 4 additions & 4 deletions packages/sst/src/runtime/handlers/container.ts
Expand Up @@ -284,8 +284,8 @@ export const useContainerHandler = (): RuntimeHandler => {
input.props.container?.cacheTo?.params
).map(([pk, pv]) => `${pk}=${pv}`)
: []
).join(","),
],
)
].join(","),,
]
: []),
`.`,
Expand Down Expand Up @@ -346,8 +346,8 @@ export const useContainerHandler = (): RuntimeHandler => {
input.props.container?.cacheTo?.params
).map(([pk, pv]) => `${pk}=${pv}`)
: []
).join(","),
],
)
].join(","),,
]
: []),
`--platform ${platform}`,
Expand Down
2 changes: 1 addition & 1 deletion packages/sst/test/constructs/Function.test.ts
Expand Up @@ -257,7 +257,7 @@ test("runtime: container: props", async () => {
{ type: "inline" },
{ type: "local", params: { src: ".", mode: "max" } },
],
cacheTo: { type: "inline" },
cacheTo: { type: "local", params: { dest: ".", mode: "max"} },
},
});
await app.finish();
Expand Down